[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4125: Rewrite users/register to Go

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #4125: Rewrite users/register to Go
URL: https://github.com/apache/trafficcontrol/pull/4125
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #3835
   
   Rewrites `/users/register` to Go. As opposed to the Perl, in this PR:
   
   - `tenantID` is required, as tenancy is no longer optional.
   - `tenantID` can no longer be a tenant to which the requesting user has no access
   - `role` can no longer be a Role with a higher privilege level than the requesting user
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   - Traffic Ops Client (Go)
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Start up Traffic Ops from this branch in an environment with access to a mail server (which is properly configured in the TO configuration file) and attempt to register users using `/users/register`.
   
   There are no unit or integration tests because this requires access to a mail server, which isn't built into the testing. There is, however, a test to ensure the email template renders given adequate input.
   
   ## The following criteria are ALL met by this PR
   - [x] I have explained why tests are impossible/impractical
   - [x] This PR includes documentation
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services