You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2023/04/11 19:09:34 UTC

[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #582: feat(c/driver/shared): created shared util library for drivers

WillAyd commented on code in PR #582:
URL: https://github.com/apache/arrow-adbc/pull/582#discussion_r1163221827


##########
c/cmake_modules/AdbcDefines.cmake:
##########
@@ -69,6 +69,15 @@ set_target_properties(nanoarrow
                                  "${REPOSITORY_ROOT}/c/vendor/"
                                  POSITION_INDEPENDENT_CODE ON)
 
+# Shared ADBC Driver libraries
+add_library(adbc_driver_shared STATIC EXCLUDE_FROM_ALL

Review Comment:
   Yea that makes more sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org