You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qianye1001 (via GitHub)" <gi...@apache.org> on 2026/09/11 08:58:45 UTC
[PR] [ISSUE #11153] Remove dedicated NameServer probe workers [rocketmq]
qianye1001 opened a new pull request, #11154:
URL: https://github.com/apache/rocketmq/pull/11154
### Which Issue(s) This PR Fixes
Fixes #11153.
### Brief Description
`NettyRemotingClient` currently submits NameServer connection probes to a dedicated pool with 4 core threads, up to 10 workers and a queue of 32 tasks. Those workers wait for connection results that Netty already exposes asynchronously.
Initiate the probes directly from the existing housekeeping timer and update availability through connection-future listeners. Remove the scan executor entirely, including its construction and shutdown, eliminating `NettyClientScan_thread_` workers. The existing scan switch and interval are retained.
The scan uses a nonblocking attempt on the existing channel-table lock so that contention defers a probe to the next scan instead of blocking housekeeping. Pending or failed connections are not advertised as available, and callbacks check the current address list, connection and shutdown state before applying results. No new executor, timer or public configuration is added.
### How Did You Test This Change?
JDK 11, with Checkstyle and SpotBugs enabled:
```shell
mvn -B -pl remoting -am -Dmaven.gitcommitid.skip=true \
-Dtest=NettyRemotingClientNameServerTest,NettyRemotingClientTest \
-Dsurefire.failIfNoSpecifiedTests=false test
```
All 26 tests passed (10 new probe tests and 16 existing client tests). Coverage includes pending connections without blocking housekeeping, connection failure and retry, address removal, replacement connections, channel-lock contention, the disabled scan switch, inactive channels and shutdown. A real TCP test verifies availability after connecting and removal after the server stops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11153] Remove dedicated NameServer probe workers [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11154:
URL: https://github.com/apache/rocketmq/pull/11154#issuecomment-5632398731
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11154?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `10 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.32%. Comparing base ([`1a50c6e`](https://app.codecov.io/gh/apache/rocketmq/commit/1a50c6e4e35524ac22055b76fc0ff2a6d3cff99f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`108ee0f`](https://app.codecov.io/gh/apache/rocketmq/commit/108ee0f3c8f15c0d11ab40faf8f7139379ce4e5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/11154?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/11154?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FNettyRemotingClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | 58.33% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/11154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11154 +/- ##
=============================================
- Coverage 49.35% 49.32% -0.04%
Complexity 14227 14227
=============================================
Files 1390 1390
Lines 103123 103130 +7
Branches 13484 13488 +4
=============================================
- Hits 50893 50865 -28
- Misses 46068 46082 +14
- Partials 6162 6183 +21
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11154?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11153] Remove dedicated NameServer probe workers [rocketmq]
Posted by "qianye1001 (via GitHub)" <gi...@apache.org>.
qianye1001 closed pull request #11154: [ISSUE #11153] Remove dedicated NameServer probe workers
URL: https://github.com/apache/rocketmq/pull/11154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org