You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/07/31 08:21:06 UTC

[PR] [Fix] Address IoTConsensus retry path Sonar issues [iotdb]

Caideyipi opened a new pull request, #18373:
URL: https://github.com/apache/iotdb/pull/18373

   ## Description
   
   This is a follow-up to #18323. Sonar reported three issues in the lock-protected SyncLog ordering and retry path.
   
   This PR:
   - documents and narrowly suppresses the cognitive/brain-method warnings on the stateful queue path;
   - introduces a short local alias for the generated i18n message constant so the retry response no longer exceeds the line-length limit.
   
   The request ordering and retry behavior are unchanged.
   
   ### Verification
   
   - ReplicateTest#syncLogWriteProcessErrorRetryPreservesRequestOrderTest: passed
   - ReplicateTest#syncLogWriteProcessErrorTriggersLeaderRetryTest: passed
   - Consensus compilation with the default and Chinese locales: passed
   - Checkstyle: 0 violations
   - Spotless and git diff --check: passed
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added a comment explaining the targeted Sonar suppression.
   - [x] been covered by the existing retry-order regression tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Fix] Address IoTConsensus retry path Sonar issues [iotdb]

Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.

Caideyipi closed pull request #18373: [Fix] Address IoTConsensus retry path Sonar issues
URL: https://github.com/apache/iotdb/pull/18373


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org