You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "minnieshi (via GitHub)" <gi...@apache.org> on 2023/03/02 10:06:45 UTC
[GitHub] [airflow] minnieshi opened a new pull request, #29870: Update index.rst - Flux helmRlease errors for jobs
minnieshi opened a new pull request, #29870:
URL: https://github.com/apache/airflow/pull/29870
how to make airflow deploy with Flux work without errors "can not patch create user job; can not patch migrate db job"
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #29870: Update index.rst - Flux helmRlease errors for jobs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #29870: Update index.rst - Flux helmRlease errors for jobs
URL: https://github.com/apache/airflow/pull/29870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29870: Update index.rst - Flux helmRlease errors for jobs
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29870:
URL: https://github.com/apache/airflow/pull/29870#discussion_r1123480088
##########
docs/helm-chart/index.rst:
##########
@@ -141,6 +141,12 @@ This is so these CI/CD services can perform updates without issues and preserve
This also applies if you install the chart using ``--wait`` in your ``helm install`` command.
+For Flux, you also need to ensure the "Jobs" are deleted and retriggered in each helmRelease, below is how you would do it:
+.. code-block:: yaml
+spec:
+ force: true # enable this to recreate resources on immutable fields changes
Review Comment:
```suggestion
.. code-block:: yaml
spec:
force: true # enable this to recreate resources on immutable fields changes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sudeepgupta90 commented on a diff in pull request #29870: Update index.rst - Flux helmRlease errors for jobs
Posted by "sudeepgupta90 (via GitHub)" <gi...@apache.org>.
sudeepgupta90 commented on code in PR #29870:
URL: https://github.com/apache/airflow/pull/29870#discussion_r1122894448
##########
docs/helm-chart/index.rst:
##########
@@ -141,6 +141,12 @@ This is so these CI/CD services can perform updates without issues and preserve
This also applies if you install the chart using ``--wait`` in your ``helm install`` command.
+For Flux, you also need to ensure the "Jobs" are deleted and retriggered in each helmRelease, below is how you would do it:
Review Comment:
I think you need to add more information/context as to where this configuration needs to go. For instance, `spec` of which object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29870: Update index.rst - Flux helmRlease errors for jobs
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29870:
URL: https://github.com/apache/airflow/pull/29870#issuecomment-1451613043
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #29870: Update index.rst - Flux helmRlease errors for jobs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29870:
URL: https://github.com/apache/airflow/pull/29870#issuecomment-1510531907
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org