You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sanjurm16 (via GitHub)" <gi...@apache.org> on 2023/07/12 18:01:14 UTC
[GitHub] [airflow] sanjurm16 opened a new pull request, #32565: #32442 fixed rendering of dagruntimeout
sanjurm16 opened a new pull request, #32565:
URL: https://github.com/apache/airflow/pull/32565
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
This resolves the below issue:
closes: #32442
The dag details page originally rendered the timedelta value as string. Causing the value of dagRunTImeout to be rendered as [object Object]. This change will handle the rendering of dagRunTimeout separately like scheduleInterval
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #32565: Fix rendering of dagRunTimeout
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #32565:
URL: https://github.com/apache/airflow/pull/32565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32565: Fix rendering of dagRunTimeout
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #32565:
URL: https://github.com/apache/airflow/pull/32565#issuecomment-1635065260
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sanjurm16 commented on a diff in pull request #32565: Fix rendering of dagRunTImeout
Posted by "sanjurm16 (via GitHub)" <gi...@apache.org>.
sanjurm16 commented on code in PR #32565:
URL: https://github.com/apache/airflow/pull/32565#discussion_r1261616394
##########
airflow/www/static/js/dag/details/Dag.tsx:
##########
@@ -291,6 +292,19 @@ const Dag = () => {
)}
</Td>
</Tr>
+ <Tr>
+ <Td>Dag run timeout</Td>
+ <Td>
+ {dagDetailsData.dagRunTimeout?.type === undefined ? (
+ <Text>null</Text>
+ ) : (
+ // for TimeDelta and RelativeDelta
+ <ViewScheduleInterval
Review Comment:
Makes sense. Let me take a look and make the change. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32565: #32442 fixed rendering of dagruntimeout
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #32565:
URL: https://github.com/apache/airflow/pull/32565#issuecomment-1632979600
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tirkarthi commented on a diff in pull request #32565: Fix rendering of dagRunTImeout
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on code in PR #32565:
URL: https://github.com/apache/airflow/pull/32565#discussion_r1261606660
##########
airflow/www/static/js/dag/details/Dag.tsx:
##########
@@ -291,6 +292,19 @@ const Dag = () => {
)}
</Td>
</Tr>
+ <Tr>
+ <Td>Dag run timeout</Td>
+ <Td>
+ {dagDetailsData.dagRunTimeout?.type === undefined ? (
+ <Text>null</Text>
+ ) : (
+ // for TimeDelta and RelativeDelta
+ <ViewScheduleInterval
Review Comment:
`ViewScheduleInterval` couples this component with dag's schedule interval. Maybe this could be refactored/renamed to `ViewTimeDelta` component to be used in schedule interval and dag run timeout to render timedelta values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org