You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/09/29 16:08:27 UTC

[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #7669: fix: substrait limit when fetch is None

waynexia commented on code in PR #7669:
URL: https://github.com/apache/arrow-datafusion/pull/7669#discussion_r1341560130


##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -442,7 +442,7 @@ impl LimitStream {
 
             match &poll {
                 Poll::Ready(Some(Ok(batch))) => {
-                    if batch.num_rows() > 0 && self.skip == 0 {

Review Comment:
   Yes. To my understanding these two conditions are identical. So I removed one to make it simpler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org