Re: AIP-6: Enforce the usage of a code formatter

[Bas Harenslak <ba...@gmail.com>]

Both good points! A linter is also definitely needed.

I made a PR replacing Flake8 by Pylint. The suggested diff tool was not useable with Pylint, but I did find a similar tool called diff-cover <https://github.com/Bachmann1234/diff-cover> which does apply Pylint only on changed lines.

The PR: https://github.com/apache/airflow/pull/4511. Let me know what you think.

Bas

> On 30 Dec 2018, at 16:03, Driesprong, Fokko <fo...@driesprong.frl> wrote:
> 
> Hi Bas,
> 
> Sounds like a good idea to me. However, applying one of the code formatters
> to the complete codebase would break all existing PR's. Maybe we can enable
> something like a diff: https://github.com/google/yapf/issues/190
> 
> Cheers, Fokko
> 
> Op zo 30 dec. 2018 om 13:42 schreef Kaxil Naik <ka...@gmail.com>:
> 
>> Not sure about code formatter but we definitely need some linting tool.
>> 
>> However, code formatter can be a positive change.
>> 
>> Regards,
>> Kaxil
>> 
>> 
>> 
>> On Sun, Dec 30, 2018, 12:12 Bas Harenslak <basharenslak@godatadriven.com
>> wrote:
>> 
>>> Wanted to point out I created an Airflow AIP for introducing a code
>>> formatter:
>>> 
>> https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-6+Enforce+the+usage+of+a+code+formatter
>>> .
>>> 
>>> I created an AIP since enforcing a code formatter will make a large
>> number
>>> of changes and result in a few PR conflicts. I wonder what peoples
>> opinion
>>> on it is.
>>> 
>>> Bas
>>> 
>>