[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #5887: feat: extra sqllogictests for scalar functions

["izveigor (via GitHub)" <gi...@apache.org>]

izveigor commented on code in PR #5887:
URL: https://github.com/apache/arrow-datafusion/pull/5887#discussion_r1158847836


##########
datafusion/core/tests/sqllogictests/test_files/scalar.slt:
##########
@@ -31,6 +31,114 @@ CREATE TABLE t1(
   (3, 10000, 978, 2048)
 ;
 
+# abs scalar function
+query RR rowsort
+select abs(64), abs(0), abs(-64)
+---
+64 0 64
+
+# acos scalar function
+query RR rowsort
+select acos(0), acos(0.5), acos(1)
+---
+1.5707963 1.0471976 0
+
+# asin scalar function
+query RR rowsort
+select asin(0), asin(0.5), asin(1)
+---
+0 1.0471976 1.5707963
+
+# atan scalar function
+query RR rowsort
+select atan(0), atan(1.7320508), atan(1)
+---
+0 1.0471976 0.7853982
+
+# atan2 scalar function
+query RR rowsort
+select atan2(0, 1), atan2(1, 2), atan2(2, 2)
+---
+1 1.0471976 1.5707963
+
+# atan2 scalar nulls
+query RR rowsort
+select atan2(null, 64) a, atan2(null) b
+----
+NULL NULL
+
+# atan2 scalar nulls 1
+query RR rowsort
+select atan2(2, null), atan2(null) b
+----
+NULL NULL
+
+# atan2 scalar nulls 2
+query RR rowsort
+select atan2(null, null), atan2(null) b
+----
+NULL NULL
+
+# ceil scalar function
+query RR rowsort
+select ceil(1.6), ceil(1.5), ceil(1.4)
+---
+1 1 1
+
+# ceil scalar nulls
+query RR rowsort
+select ceil(null)
+----
+NULL
+
+# cos scalar function
+query RR rowsort
+select cos(0), cos(1.0471976), cos(1,5707963)

Review Comment:
   I think the best option is using Pi constant: cos(0), cos(pi() / 3), cos(pi() / 2)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org