You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2019/03/13 15:08:34 UTC

[GitHub] [systemml] j143-bot commented on issue #613: [WIP][SYSTEMML-1748] Functionalize Kmeans

j143-bot commented on issue #613: [WIP][SYSTEMML-1748] Functionalize Kmeans
URL: https://github.com/apache/systemml/pull/613#issuecomment-472462950
 
 
   Hi @opengjenkins - thanks for adding this example notebook.
   
   Your notebook is fine, have two nice examples. Also, your [dml script](https://github.com/apache/systemml/blob/b9f9cb85fd3807915939113d76b358a58319effa/scripts/staging/Kmeans-functional.dml) in well into `11` nice funcs of which `4` main funcs.
   
   Although, this is good enough. Since the top level [K-means script](https://github.com/apache/systemml/blob/master/scripts/algorithms/Kmeans.dml) is well tested, reusing most of it can scale your algorithm even better.
   
   PS: A functionalized K-means could help us lead the deep learning support for systemml
    - one DL + kmean example is [Deep-K-Means](https://github.com/Sandbox3aster/Deep-K-Means-pytorch)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services