You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/10 02:00:57 UTC

[GitHub] [hudi] garyli1019 commented on a change in pull request #2930: [HUDI-1818] Validate and check required option for HoodieTable (Azure…

garyli1019 commented on a change in pull request #2930:
URL: https://github.com/apache/hudi/pull/2930#discussion_r629008388



##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##########
@@ -98,6 +102,33 @@ public String factoryIdentifier() {
   //  Utilities
   // -------------------------------------------------------------------------
 
+  /** Validate required options. e.g record key and pre combine key.
+   *
+   * @param conf The table options
+   * @param schema The table schema
+   */
+  private void validateRequiredOptions(Configuration conf, TableSchema schema) {

Review comment:
       sounds like `validateRequiredFields`? should we handle the partition field as well if it's a partitioned table?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org