You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/15 00:44:11 UTC

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17592: Add cmake build support for macOS static build.

leezu commented on a change in pull request #17592: Add cmake build support for macOS static build.
URL: https://github.com/apache/incubator-mxnet/pull/17592#discussion_r379702140
 
 

 ##########
 File path: tools/dependencies/curl.sh
 ##########
 @@ -35,6 +35,7 @@ if [[ ! -f $DEPS_PATH/lib/libcurl.a ]]; then
         CONFIG_FLAG="--with-darwinssl"
     fi
     ./configure $CONFIG_FLAG \
+                --without-libidn2 \
 
 Review comment:
   > No, there's no known security reason to avoid enabling libidn2 in curl builds.
   For generic curl builds I would recommend building with it so that users can
   use international domain names in URLs
   
   https://curl.haxx.se/mail/lib-2017-10/0158.html
   
   Why disable this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services