[jira] [Commented] (FLINK-8415) Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405750#comment-16405750 ] 

ASF GitHub Bot commented on FLINK-8415:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5724

    [FLINK-8415] Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

    ## What is the purpose of the change
    
    *This pull request marked a method as `synchronized` keyword.*
    
    
    ## Brief change log
    
      - *marked method `LongRecordWriterThread#shutdown` as `synchronized`*
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *(StreamNetworkThroughputBenchmark#tearDown)*.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8415

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5724
    
----
commit 52979c23ccdc3f868b0cd9af61292f36f67151fa
Author: yanghua <ya...@...>
Date:   2018-03-20T03:21:42Z

    [FLINK-8415] Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()

----


> Unprotected access to recordsToSend in LongRecordWriterThread#shutdown()
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8415
>                 URL: https://issues.apache.org/jira/browse/FLINK-8415
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> {code}
>   public void shutdown() {
>     running = false;
>     recordsToSend.complete(0L);
> {code}
> In other methods, access to recordsToSend is protected by synchronized keyword.
> shutdown() should do the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)