You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Kota-SH (via GitHub)" <gi...@apache.org> on 2023/04/28 17:27:06 UTC

[GitHub] [hbase] Kota-SH commented on a diff in pull request #5194: HBASE-27752: Update the block cache and list of prefetched files upon region movement

Kota-SH commented on code in PR #5194:
URL: https://github.com/apache/hbase/pull/5194#discussion_r1180653771


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -1593,7 +1595,12 @@ public Map<byte[], List<HStoreFile>> close() throws IOException {
   public static final long DEFAULT_CLOSE_WAIT_INTERVAL = 10000; // 10 seconds
 
   public Map<byte[], List<HStoreFile>> close(boolean abort) throws IOException {
-    return close(abort, false);
+    return close(abort, false, false);
+  }
+
+  public Map<byte[], List<HStoreFile>> close(boolean abort, boolean isGracefulStop)

Review Comment:
   @wchevreuil I have addressed this feedback. However, the previous UTs are probably not failing with this change here. Let's wait for the pre-commit to see how it goes this time. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org