You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/28 13:21:01 UTC
[GitHub] [superset] kgabryje commented on a change in pull request #14823: chore: Homepage cleanup
kgabryje commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r641543437
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -197,7 +206,9 @@ export default function ActivityTable({
label: t('Created'),
onClick: () => {
setActiveChild('Created');
- setInLocalStorage('activity', { activity: 'Created' });
+ setInLocalStorage(HOMEPAGE_ACTIVITY_FILTER, {
+ activity: SetTabType.CREATED,
Review comment:
Do we need to save an object to the local storage? Can't we just `setInLocalStorage(HOMEPAGE_ACTIVITY_FILTER, SetTabType.CREATED)`? Same applies to other uses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org