[GitHub] [incubator-kie-kogito-runtimes] pefernan commented on a diff in pull request #3231: [kie-issues-249] Data Index Events changes for allowing historical data

["pefernan (via GitHub)" <gi...@apache.org>]

pefernan commented on code in PR #3231:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3231#discussion_r1340390468


##########
kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java:
##########
@@ -207,11 +225,14 @@ public void testBasicUserTaskProcess() throws Exception {
         uow.end();
         assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
         events = publisher.extract();
-        assertThat(events).hasSize(2);
-        body = assertProcessInstanceEvent(events.get(0), "UserTasksProcess", "UserTasksProcess", 2);
-        assertThat(body.getNodeInstances()).hasSize(2).extractingResultOf("getNodeType").contains("HumanTaskNode", "EndNode");
-        assertThat(body.getNodeInstances()).extractingResultOf("getTriggerTime").allMatch(v -> v != null);
-        assertThat(body.getNodeInstances()).extractingResultOf("getLeaveTime").allMatch(v -> v != null);
+
+        assertProcessInstanceEvent(events.get(3), "UserTasksProcess", "UserTasksProcess", 2);

Review Comment:
   @elguardian this test is failing here... I can fix it with this:
   ```suggestion
           assertNodeInstanceEvent(events.get(3), processInstance.id(), "End Event 1", 1);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org