[GitHub] [incubator-kyuubi] link3280 commented on pull request #3521: [TEST] Fix Flink flaky test - select count

[GitBox <gi...@apache.org>]

link3280 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1251982911

   I think this could be a temporary fix if it causes instability in tests. But I can't reproduce the issue, the test runs fine on my machine.
   
   I had a glance at the git history and found that this test is for validating changes to table statistics. IMHO, row counts from table metadata should be only used for query optimization, not for the actual result set, thus I'm thinking if the assert is necessary at the beginning (or we just wanna ensure the statement runs).
   
   Pulling in the author @liaoyt for his opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org