You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Laszlo Pinter via Review Board <no...@reviews.apache.org> on 2019/09/26 16:54:50 UTC
Review Request 71550: HIVE-22137: Implement alter/rename partition
related methods on temporary tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71550/
-----------------------------------------------------------
Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
Repository: hive-git
Description
-------
HIVE-22137: Implement alter/rename partition related methods on temporary tables
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java c84c3ef595a5f26232d4f003e46f74bb14a7ec99
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java a5b16d12a514439046929dde031bbe8e80f71a28
ql/src/java/org/apache/hadoop/hive/ql/metadata/TempTable.java fa6dddcbadec59579357b9bc3d4ea42e44a1ca6f
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java 4fc3688f2e5c06e254e2177dbf142b424dcfddd8
Diff: https://reviews.apache.org/r/71550/diff/1/
Testing
-------
Thanks,
Laszlo Pinter
Re: Review Request 71550: HIVE-22137: Implement alter/rename partition
related methods on temporary tables
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71550/#review218017
-----------------------------------------------------------
Ship it!
Just one minor comment, we can fix that in a follow-up jira
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java
Lines 183-224 (patched)
<https://reviews.apache.org/r/71550/#comment305483>
I think in a follow-up jira we should move these test to the original TestAlterPartition test.
- Peter Vary
On szept. 26, 2019, 4:54 du, Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71550/
> -----------------------------------------------------------
>
> (Updated szept. 26, 2019, 4:54 du)
>
>
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-22137: Implement alter/rename partition related methods on temporary tables
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java c84c3ef595a5f26232d4f003e46f74bb14a7ec99
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java a5b16d12a514439046929dde031bbe8e80f71a28
> ql/src/java/org/apache/hadoop/hive/ql/metadata/TempTable.java fa6dddcbadec59579357b9bc3d4ea42e44a1ca6f
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java PRE-CREATION
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 6c7d80ea576d6b10af191d8ceb158c20b1f70b46
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java 4fc3688f2e5c06e254e2177dbf142b424dcfddd8
>
>
> Diff: https://reviews.apache.org/r/71550/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 71550: HIVE-22137: Implement alter/rename partition
related methods on temporary tables
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
> On Sept. 26, 2019, 5:24 p.m., Peter Vary wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java
> > Lines 208-210 (patched)
> > <https://reviews.apache.org/r/71550/diff/1/?file=2166975#file2166975line208>
> >
> > What happens when one of the alter partition fails only? How does it handled in the HMS handled tables?
I changed this part of the code. Now if this fails, the whole operation is reverted, ensuring transactional like behaviour.
> On Sept. 26, 2019, 5:24 p.m., Peter Vary wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java
> > Lines 195 (patched)
> > <https://reviews.apache.org/r/71550/diff/1/?file=2166978#file2166978line195>
> >
> > What was the original error on HMS version?
> > Why it is different here?
Changed the exception to InvalidOperationException, and added comment to IMetaStoreClient documentation.
> On Sept. 26, 2019, 5:24 p.m., Peter Vary wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java
> > Lines 201 (patched)
> > <https://reviews.apache.org/r/71550/diff/1/?file=2166978#file2166978line201>
> >
> > What was the original error on HMS version?
> > Why it is different here?
The original error is NullPointerException or TProtocolException, depending on what HMS implementation is in place.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71550/#review217953
-----------------------------------------------------------
On Sept. 26, 2019, 4:54 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71550/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2019, 4:54 p.m.)
>
>
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-22137: Implement alter/rename partition related methods on temporary tables
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java c84c3ef595a5f26232d4f003e46f74bb14a7ec99
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java a5b16d12a514439046929dde031bbe8e80f71a28
> ql/src/java/org/apache/hadoop/hive/ql/metadata/TempTable.java fa6dddcbadec59579357b9bc3d4ea42e44a1ca6f
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java PRE-CREATION
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 6c7d80ea576d6b10af191d8ceb158c20b1f70b46
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java 4fc3688f2e5c06e254e2177dbf142b424dcfddd8
>
>
> Diff: https://reviews.apache.org/r/71550/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 71550: HIVE-22137: Implement alter/rename partition
related methods on temporary tables
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71550/#review217953
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java
Lines 208-210 (patched)
<https://reviews.apache.org/r/71550/#comment305347>
What happens when one of the alter partition fails only? How does it handled in the HMS handled tables?
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java
Lines 195 (patched)
<https://reviews.apache.org/r/71550/#comment305348>
What was the original error on HMS version?
Why it is different here?
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java
Lines 201 (patched)
<https://reviews.apache.org/r/71550/#comment305349>
What was the original error on HMS version?
Why it is different here?
- Peter Vary
On szept. 26, 2019, 4:54 du, Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71550/
> -----------------------------------------------------------
>
> (Updated szept. 26, 2019, 4:54 du)
>
>
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-22137: Implement alter/rename partition related methods on temporary tables
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java c84c3ef595a5f26232d4f003e46f74bb14a7ec99
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java a5b16d12a514439046929dde031bbe8e80f71a28
> ql/src/java/org/apache/hadoop/hive/ql/metadata/TempTable.java fa6dddcbadec59579357b9bc3d4ea42e44a1ca6f
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java 4fc3688f2e5c06e254e2177dbf142b424dcfddd8
>
>
> Diff: https://reviews.apache.org/r/71550/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>