You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/28 03:13:14 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1139: HDDS-3885. Create Datanode home page
maobaolong opened a new pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139
## What changes were proposed in this pull request?
We need a Datanode home page. After this, we can do more effort to see the starttime version, build info and more information about hddsdatanode service.
## What is the link to the Apache JIRA
HDDS-3885
## How was this patch tested?
start datanode and see the root page.
http://localhost:9882/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-652122430
@adoroszlai Thank you for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi merged pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-658519947
Tested it locally. +1. Thanks @maobaolong for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-651743270
Thanks @maobaolong for updating the patch. Let's wait for others to take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-651742566
@adoroszlai Thanks for your review. AFAIK, the reason why Rpc Metrics page is empty for datanode is that datanode has no rpc service.PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r447421484
##########
File path: hadoop-hdds/container-service/src/main/resources/webapps/hddsDatanode/dn-overview.html
##########
@@ -0,0 +1,22 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<h2>Node counts</h2>
Review comment:
Nit: It seems this is leftover from SCM page. I don't think datanode page will have node counts. I'd rather replace it with "TBD" (for "To Be Done").
```suggestion
<h2>TBD</h2>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-651042710
@adoroszlai Please take a look at this PR, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r454326825
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
##########
@@ -22,13 +22,11 @@
import java.net.InetAddress;
import java.security.KeyPair;
import java.security.cert.CertificateException;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Map;
-import java.util.UUID;
+import java.util.*;
Review comment:
Import * is not recommended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on a change in pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r454330718
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
##########
@@ -22,13 +22,11 @@
import java.net.InetAddress;
import java.security.KeyPair;
import java.security.cert.CertificateException;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Map;
-import java.util.UUID;
+import java.util.*;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-658159855
@ChenSammi Thank you for correct me, PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1139:
URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-657168692
@xiaoyuyao Please take a look at this PR, if we take this PR into 0.6.0, it would be better, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org