You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/17 17:22:28 UTC

Review Request 68413: Only update profiles when getting `200 OK` in `UriDiskProfileAdaptor`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68413/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Joseph Wu.


Bugs: MESOS-9163
    https://issues.apache.org/jira/browse/MESOS-9163


Repository: mesos


Description
-------

Only updated profiles when getting `200 OK` in `UriDiskProfileAdaptor`.


Diffs
-----

  src/resource_provider/storage/uri_disk_profile_adaptor.cpp f686a43199d25d68227c7f24258e390455130dde 


Diff: https://reviews.apache.org/r/68413/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 68413: Only update profiles when getting `200 OK` in `UriDiskProfileAdaptor`.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68413/#review207515
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Aug. 17, 2018, 5:22 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68413/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 5:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-9163
>     https://issues.apache.org/jira/browse/MESOS-9163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only updated profiles when getting `200 OK` in `UriDiskProfileAdaptor`.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp f686a43199d25d68227c7f24258e390455130dde 
> 
> 
> Diff: https://reviews.apache.org/r/68413/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68413: Only update profiles when getting `200 OK` in `UriDiskProfileAdaptor`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68413/#review207531
-----------------------------------------------------------



PASS: Mesos patch 68413 was successfully built and tested.

Reviews applied: `['68413']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2186/mesos-review-68413

- Mesos Reviewbot Windows


On Aug. 17, 2018, 10:22 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68413/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 10:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-9163
>     https://issues.apache.org/jira/browse/MESOS-9163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only updated profiles when getting `200 OK` in `UriDiskProfileAdaptor`.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp f686a43199d25d68227c7f24258e390455130dde 
> 
> 
> Diff: https://reviews.apache.org/r/68413/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68413: Only update profiles when getting `200 OK` in `UriDiskProfileAdaptor`.

Posted by Gustav Paul <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68413/#review207516
-----------------------------------------------------------


Ship it!




Ship It!

- Gustav Paul


On Aug. 17, 2018, 5:22 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68413/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 5:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-9163
>     https://issues.apache.org/jira/browse/MESOS-9163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only updated profiles when getting `200 OK` in `UriDiskProfileAdaptor`.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp f686a43199d25d68227c7f24258e390455130dde 
> 
> 
> Diff: https://reviews.apache.org/r/68413/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>