You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/04 08:51:14 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #560: [YUNIKORN-1783] Application: maintain sorted state of requests instead of sorting
pbacsko opened a new pull request, #560:
URL: https://github.com/apache/yunikorn-core/pull/560
### What is this PR for?
Don't sort asks when a new one is added. Instead, maintain sorted invariant constantly as it's much more efficient.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1783
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #560: [YUNIKORN-1783] Application: maintain sorted state of requests instead of sorting
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #560:
URL: https://github.com/apache/yunikorn-core/pull/560#issuecomment-1575475722
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#560](https://app.codecov.io/gh/apache/yunikorn-core/pull/560?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (90a880c) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/c5d26a841d1f9e240620ffa6d8b805b163512bbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c5d26a8) will **decrease** coverage by `0.01%`.
> The diff coverage is `92.30%`.
> :exclamation: Current head 90a880c differs from pull request most recent head 0c1a411. Consider uploading reports for the commit 0c1a411 to get more accurate results
```diff
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 74.84% 74.83% -0.01%
==========================================
Files 70 70
Lines 11523 11546 +23
==========================================
+ Hits 8624 8641 +17
- Misses 2595 2599 +4
- Partials 304 306 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation\_ask.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `98.26% <91.42%> (-1.74%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `64.53% <100.00%> (-0.51%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #560: [YUNIKORN-1783] Application: maintain sorted state of requests instead of sorting
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #560:
URL: https://github.com/apache/yunikorn-core/pull/560#issuecomment-1575494479
`TestTryAllocatePreemptNode` is likely unrelated, I've seen this tests failing in the past multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #560: [YUNIKORN-1783] Application: maintain sorted state of requests instead of sorting
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #560: [YUNIKORN-1783] Application: maintain sorted state of requests instead of sorting
URL: https://github.com/apache/yunikorn-core/pull/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org