You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/31 18:31:18 UTC
[GitHub] [apisix] bzp2010 opened a new pull request #5985: feat: release 2.10.2
bzp2010 opened a new pull request #5985:
URL: https://github.com/apache/apisix/pull/5985
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#issuecomment-1003479159
Hi @bzp2010, do we need this? https://github.com/apache/apisix/pull/5958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r780798486
##########
File path: rockspec/apisix-2.10.3-0.rockspec
##########
@@ -0,0 +1,95 @@
+--
Review comment:
Hi, @spacewander. Do I need to make changes for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 edited a comment on pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#issuecomment-1003724597
> Merge this changelog will confuse the user about the timeline. Those fixes are in 2.10.3 but not in 2.11.0. Also, when we release 2.12.0, we have to mention some of those fixes again.
>
> And this PR doesn't update the Chinese version of CHANGELOG.
Hi, @spacewander.
I understand what you said, which may cause confusion to users.
I added a partial description of what PRs were merged into this "LTS maintenance release" for version 2.10.3 as shown below, does this ease the confusion? Or do I need to remove CHANGELOG and make it provide only in the 2.10 branch. (But a CHANGELOG in the master branch is also need? How should I do it?)
Also, I have added the Chinese version of CHANGELOG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#issuecomment-1003725456
@bzp2010
Your solution doesn't solve the problem I mention...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777794959
##########
File path: rockspec/apisix-2.10.3-0.rockspec
##########
@@ -0,0 +1,95 @@
+--
Review comment:
@spacewander Here it is marked for installation using the `2.10.3` git tag, as far as I know this could potentially be used when packaging various container images?
[https://github.com/apache/apisix-docker/blob/5d3c4c63d21f0c40655d005fdb9cb3746f2e4af3/alpine/Dockerfile#L22](https://github.com/apache/apisix-docker/blob/5d3c4c63d21f0c40655d005fdb9cb3746f2e4af3/alpine/Dockerfile#L22)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777788350
##########
File path: rockspec/apisix-2.10.3-0.rockspec
##########
@@ -0,0 +1,95 @@
+--
Review comment:
Maybe we don't need to archive this rockspec? We don't merge the code into the default branch.
##########
File path: docs/zh/latest/CHANGELOG.md
##########
@@ -79,34 +80,23 @@ title: CHANGELOG
- :sunrise: ext-plugin 避免发送重复的 conf 请求 [#5183](https://github.com/apache/apisix/pull/5183)
- :sunrise: 新增 ldap-auth 插件 [#3894](https://github.com/apache/apisix/pull/3894)
-## 2.10.2
+## 2.10.3
-### Bugfix
+**这是一个LTS维护版本，您可以在 `release/2.10` 分支中看到CHANGELOG。**
Review comment:
Better to add space around the English word
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#issuecomment-1003724597
> Merge this changelog will confuse the user about the timeline. Those fixes are in 2.10.3 but not in 2.11.0. Also, when we release 2.12.0, we have to mention some of those fixes again.
>
> And this PR doesn't update the Chinese version of CHANGELOG.
Hi, @spacewander.
I added a partial description of what PRs were merged into this "LTS maintenance release" for version 2.10.3 as shown below, does this ease the confusion? Or do I need to remove CHANGELOG and make it provide only in the 2.10 branch. (But a CHANGELOG in the master branch is also need? How should I do it?)
Also, I have added the Chinese version of CHANGELOG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777189680
##########
File path: CHANGELOG.md
##########
@@ -79,6 +80,26 @@ title: Changelog
- :sunrise: feat(ext-plugin): avoid sending conf request more times [#5183](https://github.com/apache/apisix/pull/5183)
- :sunrise: feat: Add ldap-auth plugin [#3894](https://github.com/apache/apisix/pull/3894)
+## 2.10.3
+
+### Bugfix
+
+- fix: str concat in error call [#5540](https://github.com/apache/apisix/pull/5540)
+- fix: ignore changes of /apisix/plugins/ [#5558](https://github.com/apache/apisix/pull/5558)
+- fix: invalid error after passive health check is changed [#5589](https://github.com/apache/apisix/pull/5589)
+- fix(batch-processor): we didn't free stale object actually [#5700](https://github.com/apache/apisix/pull/5700)
+- fix(patch): add global `math.randomseed` patch support [#5682](https://github.com/apache/apisix/pull/5682)
+- fix(log-rotate): after enabling compression collect log exceptions [#5715](https://github.com/apache/apisix/pull/5715)
+- feat(ext-plugin): avoid sending conf request more times [#5183](https://github.com/apache/apisix/pull/5183)
+- feat: use lock to ensure fetching token from shdict always [#5263](https://github.com/apache/apisix/pull/5263)
Review comment:
Look like some features are incorrectly backport as bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777795997
##########
File path: docs/zh/latest/CHANGELOG.md
##########
@@ -79,34 +80,23 @@ title: CHANGELOG
- :sunrise: ext-plugin 避免发送重复的 conf 请求 [#5183](https://github.com/apache/apisix/pull/5183)
- :sunrise: 新增 ldap-auth 插件 [#3894](https://github.com/apache/apisix/pull/3894)
-## 2.10.2
+## 2.10.3
-### Bugfix
+**这是一个LTS维护版本，您可以在 `release/2.10` 分支中看到CHANGELOG。**
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r780799133
##########
File path: rockspec/apisix-2.10.3-0.rockspec
##########
@@ -0,0 +1,95 @@
+--
Review comment:
I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777189680
##########
File path: CHANGELOG.md
##########
@@ -79,6 +80,26 @@ title: Changelog
- :sunrise: feat(ext-plugin): avoid sending conf request more times [#5183](https://github.com/apache/apisix/pull/5183)
- :sunrise: feat: Add ldap-auth plugin [#3894](https://github.com/apache/apisix/pull/3894)
+## 2.10.3
+
+### Bugfix
+
+- fix: str concat in error call [#5540](https://github.com/apache/apisix/pull/5540)
+- fix: ignore changes of /apisix/plugins/ [#5558](https://github.com/apache/apisix/pull/5558)
+- fix: invalid error after passive health check is changed [#5589](https://github.com/apache/apisix/pull/5589)
+- fix(batch-processor): we didn't free stale object actually [#5700](https://github.com/apache/apisix/pull/5700)
+- fix(patch): add global `math.randomseed` patch support [#5682](https://github.com/apache/apisix/pull/5682)
+- fix(log-rotate): after enabling compression collect log exceptions [#5715](https://github.com/apache/apisix/pull/5715)
+- feat(ext-plugin): avoid sending conf request more times [#5183](https://github.com/apache/apisix/pull/5183)
+- feat: use lock to ensure fetching token from shdict always [#5263](https://github.com/apache/apisix/pull/5263)
Review comment:
Look like some features are incorrectly backport as bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#issuecomment-1003496294
> Hi @bzp2010, do we need this? #5958
@juzhiyuan They will be pushed to a different branch. The use of this PR for pushing to master branch can be found in the following PR. In this release, some of the changes involved in the following PR [1] will be split into two parts to prevent affecting the master branch code.
[1] https://github.com/apache/apisix/pull/5508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #5985:
URL: https://github.com/apache/apisix/pull/5985#discussion_r777794959
##########
File path: rockspec/apisix-2.10.3-0.rockspec
##########
@@ -0,0 +1,95 @@
+--
Review comment:
@spacewander Here it is marked for installation using the `2.10.3` git tag, as far as I know this could potentially be used when packaging various container images?
[https://github.com/apache/apisix-docker/blob/5d3c4c63d21f0c40655d005fdb9cb3746f2e4af3/alpine/Dockerfile#L22](https://github.com/apache/apisix-docker/blob/5d3c4c63d21f0c40655d005fdb9cb3746f2e4af3/alpine/Dockerfile#L22)
So, IMO, we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5985: feat: release 2.10.3
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5985:
URL: https://github.com/apache/apisix/pull/5985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org