You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/14 08:49:10 UTC

[GitHub] [spark] beliefer commented on a change in pull request #24589: [MINOR][SS]Remove duplicate 'add' in comment of `StructuredSessionization`.

beliefer commented on a change in pull request #24589: [MINOR][SS]Remove duplicate 'add' in comment of `StructuredSessionization`.
URL: https://github.com/apache/spark/pull/24589#discussion_r283687056
 
 

 ##########
 File path: examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredSessionization.scala
 ##########
 @@ -70,15 +70,15 @@ object StructuredSessionization {
         line.split(" ").map(word => Event(sessionId = word, timestamp))
       }
 
-    // Sessionize the events. Track number of events, start and end timestamps of session, and
+    // Sessionize the events. Track number of events, start and end timestamps of session,
     // and report session updates.
     val sessionUpdates = events
       .groupByKey(event => event.sessionId)
       .mapGroupsWithState[SessionInfo, SessionUpdate](GroupStateTimeout.ProcessingTimeTimeout) {
 
         case (sessionId: String, events: Iterator[Event], state: GroupState[SessionInfo]) =>
 
-          // If timed out, then remove session and send final update
+          // If timed out, remove session and send final update
 
 Review comment:
   > Hm, other two occurrences are fine.
   > 
   > I'll just get this in - let's just keep the `and` typo fix only in this PR
   > 
   > ```diff
   > -    // Sessionize the events. Track number of events, start and end timestamps of session, and
   > +    // Sessionize the events. Track number of events, start and end timestamps of session,
   > ```
   
   I find another type `timestamps` and changed to `time stamps`.
   Is `Sessionize` a typo?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org