[GitHub] [druid] gianm commented on a diff in pull request #13092: Make http options the default configurations

[GitBox <gi...@apache.org>]

gianm commented on code in PR #13092:
URL: https://github.com/apache/druid/pull/13092#discussion_r972356252


##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -300,7 +300,7 @@ private void configureRunners(Binder binder)
                 binder,
                 "druid.indexer.runner.type",
                 Key.get(TaskRunnerFactory.class),
-                Key.get(ForkingTaskRunnerFactory.class)
+                Key.get(HttpRemoteTaskRunnerFactory.class)

Review Comment:
   With this change, I think there's no need for `druid.indexer.runner.type=httpRemote` in all the bundled configs anymore. Could you try removing that line and see if everything still works OK?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org