You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2023/07/12 04:28:18 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request, #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
guohao-rosicky opened a new pull request, #5048:
URL: https://github.com/apache/ozone/pull/5048
## What changes were proposed in this pull request?
Remove the redundant getBucketInfo call in OMKeyCreateRequest
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5048:
URL: https://github.com/apache/ozone/pull/5048#issuecomment-1646363319
The getBucketInfo method is called twice in OMKeyCreateRequest, so far it seems like it only needs to be called once, and although getBucketInfo is a relatively lightweight read from FullTableCache, it's still a good idea to remove the redundancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #5048:
URL: https://github.com/apache/ozone/pull/5048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ashishkumar50 commented on pull request #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on PR #5048:
URL: https://github.com/apache/ozone/pull/5048#issuecomment-1643882389
@guohao-rosicky, Thanks for the patch.
I can see one call which try to read from cache and if cache miss then it reads from db. Other call just reads from the cache. And now you are using call which just reads from the cache. Since bucket table is FULL_CACHE, I think there should not be any problem just reading from the cache here.
Change LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5048:
URL: https://github.com/apache/ozone/pull/5048#issuecomment-1646363892
> Thanks for the patch @guohao-rosicky.
>
> Changes look fine but the PR description and jira description are missing the motivation behind this change. It would be great if you could update that.
Thanks for the review @hemantk-12
Description has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #5048: HDDS-8996. Remove the redundant getBucketInfo call in OMKeyCreateRequest
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #5048:
URL: https://github.com/apache/ozone/pull/5048#issuecomment-1638469905
cc @DaveTeng0 @tanvipenumudy can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org