You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/09 22:36:29 UTC

[GitHub] [geode] onichols-pivotal edited a comment on pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

onichols-pivotal edited a comment on pull request #5196:
URL: https://github.com/apache/geode/pull/5196#issuecomment-641616445


   > @onichols-pivotal Yay, JAVA_HOME/bin/java worked! AcceptanceTests all passed.
   
   Some developers may not have JAVA_HOME set but do have `java` on their system path.  You could implement a fallback to just `java` but then you would lose a good assert.  So it seems reasonable enough to require them to set JAVA_HOME in order to run these tests locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org