You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/08/23 21:08:30 UTC
[GitHub] ascrutae commented on issue #1423: Tracing order shows error when I
use hystrix before dubbo
ascrutae commented on issue #1423: Tracing order shows error when I use hystrix before dubbo
URL: https://github.com/apache/incubator-skywalking/issues/1423#issuecomment-415571644
Cannot reproduce this produce this problem with the latest code.
BTW, I found that the trace context cannot propagate. because the dubbo plugin propagate trace context through the [RPCContext](https://github.com/apache/incubator-skywalking/blob/master/apm-sniffer/apm-sdk-plugin/dubbo-plugin/src/main/java/org/apache/skywalking/apm/plugin/dubbo/DubboInterceptor.java#L59).
> RpcContext.getContext().setAttachments(rpcContext.getAttachments());
The `RPCContext.getAttachments` method get `attachments` value from threadLocal. and Hystrix will execute `run` method in an new thread, **Not in main thread**, so current Hystrix filter cannot propagate the trace context. To resolve this problem. You should pass the `attachments` arguments. Not `RPCContext`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services