You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2018/05/21 10:22:02 UTC
Second MNG-6401
Folks,
who seconds MNG-6401 for 3.5.4? Both PRs look fine, branches pushed. All
ITs pass here.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Second MNG-6401
Posted by Robert Scholte <rf...@apache.org>.
Makes sense, let's push this to another release.
On Mon, 21 May 2018 15:47:45 +0200, Hervé BOUTEMY <he...@free.fr>
wrote:
> sorry to be a little late...
> I just commented on the issue: before merging, I'd like to have a
> clearer view
> on what's the benefit that we loose when we get back from Object
> interpolation
> to String interpolation
> and how changing the port type from int to String, with a hand written
> getter
> for compatibility and natural use as an int, would not be a more
> consistent
> option with what is done everywhere in Maven regarding interpolation of
> non-
> String fields
>
> Regards,
>
> Hervé
>
> Le lundi 21 mai 2018, 14:10:22 CEST Robert Scholte a écrit :
>> +1
>>
>> On Mon, 21 May 2018 12:22:02 +0200, Michael Osipov <mi...@apache.org>
>>
>> wrote:
>> > Folks,
>> >
>> > who seconds MNG-6401 for 3.5.4? Both PRs look fine, branches pushed.
>> All
>> > ITs pass here.
>> >
>> > Michael
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Second MNG-6401
Posted by Hervé BOUTEMY <he...@free.fr>.
sorry to be a little late...
I just commented on the issue: before merging, I'd like to have a clearer view
on what's the benefit that we loose when we get back from Object interpolation
to String interpolation
and how changing the port type from int to String, with a hand written getter
for compatibility and natural use as an int, would not be a more consistent
option with what is done everywhere in Maven regarding interpolation of non-
String fields
Regards,
Hervé
Le lundi 21 mai 2018, 14:10:22 CEST Robert Scholte a écrit :
> +1
>
> On Mon, 21 May 2018 12:22:02 +0200, Michael Osipov <mi...@apache.org>
>
> wrote:
> > Folks,
> >
> > who seconds MNG-6401 for 3.5.4? Both PRs look fine, branches pushed. All
> > ITs pass here.
> >
> > Michael
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Second MNG-6401
Posted by Robert Scholte <rf...@apache.org>.
+1
On Mon, 21 May 2018 12:22:02 +0200, Michael Osipov <mi...@apache.org>
wrote:
> Folks,
>
> who seconds MNG-6401 for 3.5.4? Both PRs look fine, branches pushed. All
> ITs pass here.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org