You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/28 22:32:29 UTC

[GitHub] [flink] nryanov opened a new pull request #10021: [hotfix][typo] Rename withNewBucketAssignerAnd[Rolling]Policy

nryanov opened a new pull request #10021: [hotfix][typo] Rename withNewBucketAssignerAnd[Rolling]Policy
URL: https://github.com/apache/flink/pull/10021
 
 
   ## What is the purpose of the change
   There are two existing methods in StreamingFileSink:
   withRollingPolicy and withBucketAssigner which can be used separately. Also there is method withNewBucketAssignerAndPolicy which can be used as replacement for two mentioned methods. 
   It seems that this method should be named as withNewBucketAssignerAndRollingPolicy.
   
   ## Brief change log
   Rename method withNewBucketAssignerAndPolicy to withNewBucketAssignerAnd**Rolling**Policy
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes (?)
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services