Re: [PR] Create a new singleton metric with an API_NAME tag [polaris]

["collado-mike (via GitHub)" <gi...@apache.org>]

collado-mike commented on code in PR #431:
URL: https://github.com/apache/polaris/pull/431#discussion_r1833125182


##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
 @Provider
 public class TimedApplicationEventListener implements ApplicationEventListener {
 
+  public static final String METRIC_NAME = "polaris.TimedApi";
+  public static final String TAG_API_NAME = "API_NAME";

Review Comment:
   I think tag names should be lowercase



##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
 @Provider
 public class TimedApplicationEventListener implements ApplicationEventListener {
 
+  public static final String METRIC_NAME = "polaris.TimedApi";

Review Comment:
   Does this get prefixed to the existing metric name? E.g., currently we publish `polaris.CatalogApi.commitTransaction`. Will it now be `polaris.TimedApi.polaris.CatalogApi.commitTransaction`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org