You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/11 16:26:28 UTC

[kudu-CR] Attempt to make tablet copy client session-itest less flaky

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5468

to review the following change.

Change subject: Attempt to make tablet_copy_client_session-itest less flaky
......................................................................

Attempt to make tablet_copy_client_session-itest less flaky

I'm having trouble reproducing the errors seen on EC2 but I'm hoping
this will make the test less flaky on the test dashboard. Let's see.

Change-Id: If076e7997e95335d25346492938764ccb283f813
---
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
1 file changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5468/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If076e7997e95335d25346492938764ccb283f813
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Attempt to make tablet copy client session-itest less flaky

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Attempt to make tablet_copy_client_session-itest less flaky
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If076e7997e95335d25346492938764ccb283f813
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Attempt to make tablet copy client session-itest less flaky

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Attempt to make tablet_copy_client_session-itest less flaky
......................................................................


Attempt to make tablet_copy_client_session-itest less flaky

I'm having trouble reproducing the errors seen on EC2 but I'm hoping
this will make the test less flaky on the test dashboard. Let's see.

Change-Id: If076e7997e95335d25346492938764ccb283f813
Reviewed-on: http://gerrit.cloudera.org:8080/5468
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
1 file changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If076e7997e95335d25346492938764ccb283f813
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>