[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3728: server: double check host capacity when start/migrate a vm

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3728: server: double check host capacity when start/migrate a vm
URL: https://github.com/apache/cloudstack/pull/3728#discussion_r362812183
 
 

 ##########
 File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -2349,6 +2349,17 @@ protected void migrate(final VMInstanceVO vm, final long srcHostId, final Deploy
             _networkMgr.rollbackNicForMigration(vmSrc, profile);
             s_logger.info("Migration cancelled because " + e1.getMessage());
             throw new ConcurrentOperationException("Migration cancelled because " + e1.getMessage());
+        } catch (final CloudRuntimeException e2) {
+            _networkMgr.rollbackNicForMigration(vmSrc, profile);
+            s_logger.info("Migration cancelled because " + e2.getMessage());
+            work.setStep(Step.Done);
+            _workDao.update(work.getId(), work);
+            try {
+                stateTransitTo(vm, Event.OperationFailed, srcHostId);
+            } catch (final NoTransitionException e3) {
+                s_logger.warn(e3.getMessage());
+            }
+            throw new CloudRuntimeException("Migration cancelled because " + e2.getMessage());
 
 Review comment:
   can we add the cause or log its stack-trace before abandoning it here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services