You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2024/12/28 15:19:22 UTC
[PR] [MINOR] Fix edgecase of Compressed OffsetSlice [systemds]
Baunsgaard opened a new pull request, #2163:
URL: https://github.com/apache/systemds/pull/2163
This commit fixes an edgecase of offset slices where a single element is sliced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix edgecase of Compressed OffsetSlice [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2163: [MINOR] Fix edgecase of Compressed OffsetSlice
URL: https://github.com/apache/systemds/pull/2163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix edgecase of Compressed OffsetSlice [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2163:
URL: https://github.com/apache/systemds/pull/2163#issuecomment-2564365536
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2163?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 72.06%. Comparing base [(`5ac091a`)](https://app.codecov.io/gh/apache/systemds/commit/5ac091a20bc9e8af7886ab2c45219e6c01e1d2ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8d380c3`)](https://app.codecov.io/gh/apache/systemds/commit/8d380c3d5ba6236a7579e71d8aadaff793fc4b99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2163?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ysds/runtime/compress/colgroup/offset/AOffset.java](https://app.codecov.io/gh/apache/systemds/pull/2163?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2Foffset%2FAOffset.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvb2Zmc2V0L0FPZmZzZXQuamF2YQ==) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2163 +/- ##
============================================
- Coverage 72.06% 72.06% -0.01%
+ Complexity 43975 43974 -1
============================================
Files 1443 1443
Lines 166255 166260 +5
Branches 32456 32458 +2
============================================
- Hits 119818 119816 -2
+ Misses 37188 37181 -7
- Partials 9249 9263 +14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2163?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org