You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/03 12:20:14 UTC

[GitHub] [spark] Yikun commented on pull request #37369: [SPARK-39942][PYTHON][PS] Need to verify the input nums is integer in nsmallest func

Yikun commented on PR #37369:
URL: https://github.com/apache/spark/pull/37369#issuecomment-1203876107

   > is there some method to enforce the input type checking?
   
   I did some try on strict type check for pyspark in last year (long long ago): https://github.com/Yikun/annotation-type-checker/pull/4
   
   We could easy to [add decorator to enable type check](https://github.com/Yikun/annotation-type-checker/blob/c97158bab04afb3fd10f37a73fd9d37b22e135c8/test_type_checker.py#L10) without any 3rd lib introduced.
   
   But if we enable this, the type check will be the first priority validation, this might bring some different behavior with pandas finally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org