You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/09 08:29:33 UTC

[GitHub] [pulsar] wangjialing218 opened a new pull request #9541: Add producer metrics for Prometheus

wangjialing218 opened a new pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541


   ### Motivation
   There are subscriptions and consumers metrics for prometheus but miss producers' metrics.
   
   ### Modifications
   1. Add producer metrics for prometheus.
   2. Add a configration for whether export producer metrics, default is false.
   
   ### Verifying this change
   Add test case testPerProducerStats() in PrometheusMetricsTest
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API: ( no)
     - The schema: ( no)
     - The default values of configurations: ( no)
     - The wire protocol: ( no)
     - The rest endpoints: ( no)
     - The admin cli options: ( no)
     - Anything that affects deployment: ( no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #9541: Add producer metrics for Prometheus

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541#issuecomment-785827525


   Because this PR changes the `generate` method will break some PRs in branch 2.7. And this PR is not introduced some protocol changes so it's ok to cherry-pick to branch 2.7.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap removed a comment on pull request #9541: Add producer metrics for Prometheus

Posted by GitBox <gi...@apache.org>.
zymap removed a comment on pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541#issuecomment-785827525


   Because this PR changes the `generate` method will break some PRs in branch 2.7. And this PR is not introduced some protocol changes so it's ok to cherry-pick to branch 2.7.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9541: Add producer metrics for Prometheus

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaoran10 commented on pull request #9541: Add producer metrics for Prometheus

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541#issuecomment-776046382


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #9541: Add producer metrics for Prometheus

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #9541:
URL: https://github.com/apache/pulsar/pull/9541#issuecomment-778766962


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org