You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/05/19 01:09:00 UTC

[GitHub] [trafficserver] ywkaras commented on pull request #6800: Add TXN_CLOSE hook to CPPAPI TransactionPlugin

ywkaras commented on pull request #6800:
URL: https://github.com/apache/trafficserver/pull/6800#issuecomment-630515931


   In the state dump, in frame #4, it seems to be showing the parameters in the reverse order from what they are declared in the function:  https://github.com/apache/trafficserver/blob/bf097d4289a3eaa3759a58fb19e48381b89ce32f/src/tscpp/api/utils_internal.cc#L113
   The event parameter is not TS_EVENT_HTTP_TXN_CLOSE (60012).
   
   When the TXN_CLOSE hook is triggered, the CPPAPI destroys the instance of your custom class that is derived from TransactionPlugin.  So you are supposed to put anything you want to run on that hook in the destructor of that class.  Because continuations on hooks run in arbitrary order, I think your change could cause a use after free.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org