You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/16 07:32:04 UTC

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #19986: [FLINK-28081][config] Remove deprecated Hadoop specific Flink configuration options

gaborgsomogyi commented on code in PR #19986:
URL: https://github.com/apache/flink/pull/19986#discussion_r898783294


##########
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java:
##########
@@ -77,47 +75,18 @@ public static Configuration getHadoopConfiguration(
 
         for (String possibleHadoopConfPath : possibleHadoopConfPaths) {
             if (possibleHadoopConfPath != null) {
-                foundHadoopConfiguration = addHadoopConfIfFound(result, possibleHadoopConfPath);
+                foundHadoopConfiguration |= addHadoopConfIfFound(result, possibleHadoopConfPath);

Review Comment:
   This is a simple boolean arithmetic in order not to overwrite the first round true with a second round false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org