You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/01/17 10:56:13 UTC

[GitHub] zeppelin pull request #2732: [ZEPPELIN-3172] Support for carriage return '\r...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2732

    [ZEPPELIN-3172] Support for carriage return '\r', on result window

    ### What is this PR for?
    This got introduced while trying to fix html/xml rendering https://github.com/apache/zeppelin/pull/2729/commits/7851c130cf62fc7ff2281d1cf2c6f25658829fe5
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * [ZEPPELIN-3172]
    
    ### How should this be tested?
    Here is a sample code to test it
    
    ```
    %python
    import time,sys
    end_val = 10
    bar_length = 20
    for i in xrange(0, end_val + 1):
        time.sleep(0.5)
        percent = float(i) / end_val
        hashes = '#' * int(round(percent * bar_length))
        spaces = ' ' * (bar_length - len(hashes))
        sys.stdout.write("\rPercent: [{0}] {1}%".format(hashes + spaces, int(round(percent * 100))))
        #print "Percent: [{0}] {1}%".format(hashes + spaces, int(round(percent * 100)))
    ```
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3172

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2732
    
----
commit e3c2162ddc208b7f75ad5a2763996e88bfa34fcf
Author: Prabhjyot Singh <pr...@...>
Date:   2018-01-17T10:53:51Z

    fix contained html/xml
    
    Change-Id: I60c02435e312a9898de41ca59458c84d467e19be

----


---

[GitHub] zeppelin pull request #2732: [ZEPPELIN-3172] Support for carriage return '\r...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2732


---

[GitHub] zeppelin issue #2732: [ZEPPELIN-3172] Support for carriage return '\r', on r...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2732
  
    Tested locally, works well. Thanks @prabhjyotsingh 


---

[GitHub] zeppelin issue #2732: [ZEPPELIN-3172] Support for carriage return '\r', on r...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2732
  
    @zjffdu  Please help review this.


---

[GitHub] zeppelin issue #2732: [ZEPPELIN-3172] Support for carriage return '\r', on r...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2732
  
    Thanks for the review, will merge this soon.


---