You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:37:47 UTC

[GitHub] [superset] rusackas commented on pull request #19723: chore(frontend): captialize reports for ocd relief

rusackas commented on PR #19723:
URL: https://github.com/apache/superset/pull/19723#issuecomment-1110499161

   Pinging @mihir174 and @jess-dillard for more design input here, but my two cents are that `&` should not be an exception. It's cap height, which probably does make it a little odd, but I'd almost rather replace it with `and` than bend or break the rule we're still trying to spread around the UI consistently. 
   
   If we DO decide to go with that decision and close this, we should add a rule about `&` to the style guideline :) It's a good callout, @cemremengu and I/we appreciate the contribution/consideration!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org