You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/03/13 08:25:20 UTC

[GitHub] [incubator-livy] WeiWenda opened a new pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool

WeiWenda opened a new pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool
URL: https://github.com/apache/incubator-livy/pull/135
 
 
   ## What changes were proposed in this pull request?
   make interpreterExecutor run with newFixedThreadPool  rather than newSingleThreadExecutor
   https://issues.apache.org/jira/browse/LIVY-544
   
   ## How was this patch tested?
   we run a jmeter test of 20 threads each post statement 1/60s, set "spark.scheduler.mode": "FAIR"
   we find setJobGroup is not thread-safe causing some reflect Error, so wrap it by Session.synchronized
   > this.synchronized{ setJobGroup(tpe, statementId) }
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services