You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/01 16:11:26 UTC
[GitHub] [spark] rdblue commented on a change in pull request #24469:
[SPARK-27576][SQL] table capability to skip the output column resolution
rdblue commented on a change in pull request #24469: [SPARK-27576][SQL] table capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#discussion_r280121827
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NamedRelation.scala
##########
@@ -21,4 +21,7 @@ import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
trait NamedRelation extends LogicalPlan {
def name: String
+
+ // When true, the schema of input data must match the schema of this relation, during write.
+ def requireSchemaMatch: Boolean = true
Review comment:
I agree that the "ignore" form is better.
I don't think that the term "schema match" is clear though, because it is not obvious what "match" means. What about `skipSchemaResolution` or `skipSchemaValidation`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org