[GitHub] merlimat commented on a change in pull request #1850: Ship git info in jar and print at boot

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1850: Ship git info in jar and print at boot
URL: https://github.com/apache/incubator-pulsar/pull/1850#discussion_r191505816
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -308,6 +308,13 @@ public ServiceConfiguration getConfiguration() {
     public void start() throws PulsarServerException {
         mutex.lock();
 
+        LOG.info("Starting Pulsar Broker service; version: '{}'", ( brokerVersion != null ? brokerVersion : "unknown" )  );
+        LOG.info("Git Revision {}", PulsarBrokerVersionStringUtils.getGitSha());
+        LOG.info("Built by {} on {} at {}",
+                 PulsarBrokerVersionStringUtils.getBuildUser(),
+                 PulsarBrokerVersionStringUtils.getBuildHost(),
 
 Review comment:
   Regarding the user/buildhost, these would typically be the ones of who's making the release. The question is that they might not be helpful for a users and they might expose information from that machine. Also user name might not be relatable with apache id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services