[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1572: MINIFICPP-2027 Upgrade Google Cloud library to version 2.10.1

["lordgamez (via GitHub)" <gi...@apache.org>]

lordgamez commented on code in PR #1572:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1572#discussion_r1211872671


##########
extensions/gcp/tests/GCPCredentialsControllerServiceTests.cpp:
##########
@@ -89,7 +105,7 @@ TEST_F(GCPCredentialsTests, DefaultGCPCredentialsWithEnv) {
   auto temp_directory = test_controller_.createTempDirectory();
   auto path = create_mock_json_file(temp_directory);
   ASSERT_TRUE(path.has_value());
-  google::cloud::internal::SetEnv("GOOGLE_APPLICATION_CREDENTIALS", path->string());
+  setGoogleEnvironmentCredentials(path->string().c_str());

Review Comment:
   That was my first thought, but unfortunately it does not work on Windows. In `setEnvironmentVariable` the `SetEnvironmentVariableA` which is different from the `_putenv_s`. For the changes to be visible for the Google library we need to use `_putenv_s`. The difference is explained here: https://github.com/googleapis/google-cloud-cpp/issues/100#issuecomment-357246853



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org