You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/24 19:17:22 UTC
[GitHub] [shardingsphere] linghengqian opened a new issue, #19510: The io.takari:maven plugin should probably be removed
linghengqian opened a new issue, #19510:
URL: https://github.com/apache/shardingsphere/issues/19510
## Question
**For English only**, other languages will not accept.
Before asking a question, make sure you have:
- Googled your question.
- Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues).
- Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will **close it**.
- A long-unupdated Maven plugin is used in the `pom.xml` of the current master branch.
```
<plugin>
<groupId>io.takari</groupId>
<artifactId>maven</artifactId>
<version>${takari-maven-plugin.version}</version>
</plugin>
```
- According to the information provided at https://mvnrepository.com/artifact/io.takari/maven/0.7.7 , this plugin actually serves `io.takari:maven-wrapper:0.5.6` which has been discontinued for maintenance.
- The Maven Wrapper has been replaced with the version under Apache Org at https://github.com/apache/shardingsphere/pull/14258 , so this plugin seems moot and removing it is expected behavior.
-
https://github.com/apache/shardingsphere/pull/14258 doesn't remove `.mvn/wrapper/MavenWrapperDownloader.java` , which doesn't seem like a reasonable choice. Since `./mvnw` will automatically download the Maven Wrapper JAR via `wget` or `curl` if `MavenWrapperDownloader.java` does not exist, this class is not needed in my understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #19510: The io.takari:maven plugin should probably be removed
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #19510:
URL: https://github.com/apache/shardingsphere/issues/19510#issuecomment-1193583503
Yes, I am working on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #19510: The io.takari:maven plugin should probably be removed
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #19510:
URL: https://github.com/apache/shardingsphere/issues/19510#issuecomment-1193573252
Awesome, could you try to remove it and upgrade the version of mvnw as a pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #19510: The io.takari:maven plugin should probably be removed
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #19510: The io.takari:maven plugin should probably be removed
URL: https://github.com/apache/shardingsphere/issues/19510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org