You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/13 07:57:01 UTC

[jira] Created: (HARMONY-340) javac source and target properties should be moved to top-level property file

javac source and target properties should be moved to top-level property file
-----------------------------------------------------------------------------

         Key: HARMONY-340
         URL: http://issues.apache.org/jira/browse/HARMONY-340
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Minor


Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-340?page=all ]
     
Stepan Mishura closed HARMONY-340:
----------------------------------


Verified by Mark.

> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff, regex.javac.properties.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-340?page=all ]

Mark Hindess updated HARMONY-340:
---------------------------------

    Attachment: regex.javac.properties.diff

We should probably fix the newly integrated regex module too.  I've attached a patch.


> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff, regex.javac.properties.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-340?page=comments#action_12374843 ] 

Stepan Mishura commented on HARMONY-340:
----------------------------------------

Thanks Mark, 

Patch for regex was applied at repo revision 394834. 

Please check that the patch was applied as you expected.

> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff, regex.javac.properties.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-340?page=all ]

Mark Hindess updated HARMONY-340:
---------------------------------

    Attachment: javac.property.refactoring.diff

Patch changes ant files so that they import the top-level property file.  I've also removed the duplicate platform property stuff since this is done in the imported file.  And similarly I fixed the top level make/build.xml snapshot target to use the new platform properties (and added the md5 sum generation - 2 lines - at the same time).


> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-340?page=all ]
     
Stepan Mishura resolved HARMONY-340:
------------------------------------

    Resolution: Fixed

Thanks Mark,

Patch was applied at repo revision 394034.

There were version conflicts in make/build.xml and make/build-test.xml files. Please check that the patch was applied as you expected and the conflicts were resolved properly.


> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-340?page=all ]

Stepan Mishura reassigned HARMONY-340:
--------------------------------------

    Assign To: Stepan Mishura

> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-340) javac source and target properties should be moved to top-level property file

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-340?page=comments#action_12374848 ] 

Mark Hindess commented on HARMONY-340:
--------------------------------------

Looks good now. Thanks Stepan.

> javac source and target properties should be moved to top-level property file
> -----------------------------------------------------------------------------
>
>          Key: HARMONY-340
>          URL: http://issues.apache.org/jira/browse/HARMONY-340
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: javac.property.refactoring.diff, regex.javac.properties.diff
>
> Will attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira