You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-user@lucene.apache.org by Artem Karpenko <a....@oxseed.com> on 2013/07/29 11:04:03 UTC

.lock file not created when making a backup snapshot

Hi,

when making a backup snapshot using "/replication?command=backup" call, 
a snapshot directory is created and starts to be filled, but appropriate 
.lock file is not created so it's impossible to check when backup is 
finished. I've taken a look at code and it seems to me that 
lock.obtain() call is missing: there is

public class SnapShooter {
...
void createSnapshot(final IndexCommit indexCommit, int numberToKeep, 
ReplicationHandler replicationHandler) {
...
lock = lockFactory.makeLock(directoryName + ".lock");
...
lock.release();

so lock file is not actually created. This is Solr 4.3.1, release notes 
for Solr 4.4 do not include this problem.

Should I raise a JIRA issue for this? Or maybe you could suggest more 
reliable way to make a backup?

Regards,
Artem.

Re: .lock file not created when making a backup snapshot

Posted by Artem Karpenko <a....@oxseed.com>.

Thanks Mark!

29.07.2013 12:32, Mark Triggs пишет:
> Hi Artem,
>
> I noticed this recently too.  I created a JIRA issue here:
>
>    https://issues.apache.org/jira/browse/SOLR-5040
>
> Cheers,
>
> Mark
>
>
> Artem Karpenko <a....@oxseed.com> writes:
>
>> Hi,
>>
>> when making a backup snapshot using "/replication?command=backup"
>> call, a snapshot directory is created and starts to be filled, but
>> appropriate .lock file is not created so it's impossible to check when
>> backup is finished. I've taken a look at code and it seems to me that
>> lock.obtain() call is missing: there is
>>
>> public class SnapShooter {
>> ...
>> void createSnapshot(final IndexCommit indexCommit, int numberToKeep,
>> ReplicationHandler replicationHandler) {
>> ...
>> lock = lockFactory.makeLock(directoryName + ".lock");
>> ...
>> lock.release();
>>
>> so lock file is not actually created. This is Solr 4.3.1, release
>> notes for Solr 4.4 do not include this problem.
>>
>> Should I raise a JIRA issue for this? Or maybe you could suggest more
>> reliable way to make a backup?
>>
>> Regards,
>> Artem.

Re: .lock file not created when making a backup snapshot

Posted by Mark Triggs <ma...@dishevelled.net>.

Hi Artem,

I noticed this recently too.  I created a JIRA issue here:

  https://issues.apache.org/jira/browse/SOLR-5040

Cheers,

Mark


Artem Karpenko <a....@oxseed.com> writes:

> Hi,
>
> when making a backup snapshot using "/replication?command=backup"
> call, a snapshot directory is created and starts to be filled, but
> appropriate .lock file is not created so it's impossible to check when
> backup is finished. I've taken a look at code and it seems to me that
> lock.obtain() call is missing: there is
>
> public class SnapShooter {
> ...
> void createSnapshot(final IndexCommit indexCommit, int numberToKeep,
> ReplicationHandler replicationHandler) {
> ...
> lock = lockFactory.makeLock(directoryName + ".lock");
> ...
> lock.release();
>
> so lock file is not actually created. This is Solr 4.3.1, release
> notes for Solr 4.4 do not include this problem.
>
> Should I raise a JIRA issue for this? Or maybe you could suggest more
> reliable way to make a backup?
>
> Regards,
> Artem.

-- 
Mark Triggs
<ma...@dishevelled.net>