[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1813: ci: Fix build for nodejs binding on macos

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #1813:
URL: https://github.com/apache/incubator-opendal/pull/1813#discussion_r1153979855


##########
bindings/nodejs/package.json:
##########
@@ -59,15 +59,12 @@
     "node": ">= 10"
   },
   "scripts": {
-    "artifacts": "napi artifacts",
-    "build": "napi build --platform --release --js generated.js && node ./scripts/header.js",
-    "build:debug": "napi build --platform --js generated.js && node ./scripts/header.js",
+    "build": "napi build --platform --target \"${NAPI_TARGET:-}\" --release --js generated.js && node ./scripts/header.js",
+    "build:debug": "napi build --platform --target \"${NAPI_TARGET:-}\" --js generated.js && node ./scripts/header.js",
     "docs": "typedoc",
     "format": "prettier --write .",
-    "prepublishOnly": "napi prepublish -t npm",

Review Comment:
   We will never do publish by hand, so their no need for such script in `package.json`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org