You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by lh...@apache.org on 2013/02/04 20:31:59 UTC

svn commit: r1442305 - /shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java

Author: lhazlewood
Date: Mon Feb  4 19:31:59 2013
New Revision: 1442305

URL: http://svn.apache.org/viewvc?rev=1442305&view=rev
Log:
SHIRO-415: Updated isLoginAttempt(String authzHeader) to use English Locale

Modified:
    shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java

Modified: shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java
URL: http://svn.apache.org/viewvc/shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java?rev=1442305&r1=1442304&r2=1442305&view=diff
==============================================================================
--- shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java (original)
+++ shiro/branches/1.2.x/web/src/main/java/org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java Mon Feb  4 19:31:59 2013
@@ -28,6 +28,7 @@ import javax.servlet.ServletRequest;
 import javax.servlet.ServletResponse;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import java.util.Locale;
 
 
 /**
@@ -251,8 +252,9 @@ public class BasicHttpAuthenticationFilt
      *         the {@link #getAuthzScheme() authzScheme}.
      */
     protected boolean isLoginAttempt(String authzHeader) {
-        String authzScheme = getAuthzScheme().toLowerCase();
-        return authzHeader.toLowerCase().startsWith(authzScheme);
+        //SHIRO-415: use English Locale:
+        String authzScheme = getAuthzScheme().toLowerCase(Locale.ENGLISH);
+        return authzHeader.toLowerCase(Locale.ENGLISH).startsWith(authzScheme);
     }
 
     /**