You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "jiahuili430 (via GitHub)" <gi...@apache.org> on 2023/03/06 14:07:39 UTC
[GitHub] [couchdb] jiahuili430 opened a new pull request, #4457: Documentation: Add `adm:pass` to replication endpoint URL
jiahuili430 opened a new pull request, #4457:
URL: https://github.com/apache/couchdb/pull/4457
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
When using replication, we need to specify a username and password (`adm:pass` / `admin:password`) for the replication endpoint URL, otherwise a 401 unauthorized error will be thrown.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provide any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
Fix https://github.com/apache/couchdb/issues/4127
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [x] Documentation changes were made in the `src/docs` folder
- [ ] Documentation changes were backported (separated PR) to affected branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #4457:
URL: https://github.com/apache/couchdb/pull/4457#discussion_r1126561219
##########
src/docs/src/replication/replicator.rst:
##########
@@ -252,16 +252,16 @@ normal.
Documents describing the same replication
=========================================
-Lets suppose 2 documents are added to the ``_replicator`` database in
+Let's suppose 2 documents are added to the ``_replicator`` database in
the following order:
.. code-block:: javascript
{
"_id": "my_rep",
- "source": "http://myserver.com/foo",
- "target": "http://user:pass@localhost:5984/bar",
- "create_target": true,
+ "source": "http://adm:pass@myserver.com/foo",
Review Comment:
Yeah, that were my thoughts too, but great work @jiahuili430 so far, it's almost ready already...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4457:
URL: https://github.com/apache/couchdb/pull/4457#discussion_r1126520455
##########
src/docs/src/replication/replicator.rst:
##########
@@ -252,16 +252,16 @@ normal.
Documents describing the same replication
=========================================
-Lets suppose 2 documents are added to the ``_replicator`` database in
+Let's suppose 2 documents are added to the ``_replicator`` database in
the following order:
.. code-block:: javascript
{
"_id": "my_rep",
- "source": "http://myserver.com/foo",
- "target": "http://user:pass@localhost:5984/bar",
- "create_target": true,
+ "source": "http://adm:pass@myserver.com/foo",
Review Comment:
In a few cases, where we have a remote endpoint like "myserver.com" we may want to use a different password user combination to illustrate that those endpoint may have a completely different set of credentials. So in this case we could have source have a `user:password` for instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiahuili430 commented on a diff in pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "jiahuili430 (via GitHub)" <gi...@apache.org>.
jiahuili430 commented on code in PR #4457:
URL: https://github.com/apache/couchdb/pull/4457#discussion_r1126630795
##########
src/docs/src/replication/replicator.rst:
##########
@@ -252,16 +252,16 @@ normal.
Documents describing the same replication
=========================================
-Lets suppose 2 documents are added to the ``_replicator`` database in
+Let's suppose 2 documents are added to the ``_replicator`` database in
the following order:
.. code-block:: javascript
{
"_id": "my_rep",
- "source": "http://myserver.com/foo",
- "target": "http://user:pass@localhost:5984/bar",
- "create_target": true,
+ "source": "http://adm:pass@myserver.com/foo",
Review Comment:
Changed, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4457:
URL: https://github.com/apache/couchdb/pull/4457#issuecomment-1456224009
Hi @jiahuili430,
thanks for taking a look and fixing this. Do you only concentrate to fix the `/_replicate` endpoint, or do you search for other occurences of this behavior in the docs as Nick suggested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiahuili430 commented on pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "jiahuili430 (via GitHub)" <gi...@apache.org>.
jiahuili430 commented on PR #4457:
URL: https://github.com/apache/couchdb/pull/4457#issuecomment-1456233902
I only checked the `1.7.4 Replication` and `2. Replication` sections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4457: Documentation: Add `adm:pass` to replication endpoint URL
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 merged PR #4457:
URL: https://github.com/apache/couchdb/pull/4457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org