You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/12/01 13:18:53 UTC
Re: Review Request 40706: Clarified a comment for `Accept` call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40706/#review108481
-----------------------------------------------------------
include/mesos/scheduler/scheduler.proto (line 229)
<https://reviews.apache.org/r/40706/#comment167939>
Sorry to be nit-picky about such a trivial change, but could we keep this comment consistent with other places (e.g. `include/mesos/scheduler.hpp`)?
```
Available resources are aggregated when multiple offers are provided. Note that all offers must belong to the same slave.
```
Maybe we could just do:
```
NOTE: All offers must belong to the same agent.
```
- Michael Park
On Nov. 30, 2015, 10:47 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40706/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 10:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 7bf447e07665dd33646edd0c684ab559712631cc
>
> Diff: https://reviews.apache.org/r/40706/diff/
>
>
> Testing
> -------
>
> not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>